Fix narrowing from object to Optional #4118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukkaL
approved these changes
Oct 26, 2017
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix!
JukkaL
pushed a commit
that referenced
this pull request
Oct 31, 2017
Previously: ``` x: object y: Optional[int] x = y reveal_type(x) # builtins.int ``` This was unexpected and may be unsafe. Fix this by considering object as overlapping with everything (including None).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently:
this is unexpected and may be unsafe. This PR fixes this by considering
objectas overlapping with everything (includingNone).